Skip to content

Conversation

@jcornall
Copy link
Contributor

@jcornall jcornall commented Nov 3, 2025

Description:

Refactoring of the send_decom_image_email workflow in line with wider StackStorm workflow refactoring.

The find_servers_with_image and list_to_regex_pattern functions have been moved from the workflow to a dedicated module within the /apis/openstack_query_api directory called server_queries. Unit tests have been updated.

Note: this PR is dependent on changes to user_queries made in #404.

Special Notes:


Submitter:

Have you (where applicable):

  • Added unit tests?
  • Checked the latest commit runs on Dev?
  • Updated the example config file(s) and README?

Reviewer

Does this PR:

  • Place non-StackStorm code into the lib directory?
  • Have unit tests for the action/sensor and lib layers?
  • Have clear and obvious action parameter names and descriptions?

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.92%. Comparing base (35418aa) to head (37de106).
⚠️ Report is 5 commits behind head on refactor_email_workflows.

Files with missing lines Patch % Lines
lib/workflows/send_decom_image_email.py 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           refactor_email_workflows     #405      +/-   ##
============================================================
- Coverage                    100.00%   99.92%   -0.08%     
============================================================
  Files                           107      108       +1     
  Lines                          2609     2607       -2     
  Branches                        320      319       -1     
============================================================
- Hits                           2609     2605       -4     
- Misses                            0        1       +1     
- Partials                          0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jcornall jcornall force-pushed the decom-image-email-workflow branch 2 times, most recently from 2f349df to f89d564 Compare November 5, 2025 10:59
@jcornall jcornall changed the base branch from main to refactor_email_workflows November 5, 2025 11:44
@jcornall jcornall force-pushed the decom-image-email-workflow branch from e32ba3e to 5be0ad9 Compare November 6, 2025 11:46
@jcornall jcornall marked this pull request as ready for review November 6, 2025 11:49
@jcornall jcornall force-pushed the decom-image-email-workflow branch from 5be0ad9 to 37de106 Compare November 6, 2025 16:51
@jose-caballero jose-caballero self-requested a review November 10, 2025 08:35
@jose-caballero jose-caballero merged commit 8858e65 into refactor_email_workflows Nov 10, 2025
10 of 12 checks passed
@jose-caballero jose-caballero deleted the decom-image-email-workflow branch November 10, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants