fix: post AI review comments inline to actual files instead of single giant comment#27
Closed
adslaton wants to merge 4 commits into
Closed
fix: post AI review comments inline to actual files instead of single giant comment#27adslaton wants to merge 4 commits into
adslaton wants to merge 4 commits into
Conversation
… giant comment - Update postSuggestionsToGitHub() to post ALL suggestions as inline comments - Create generateAllInlineComments() method to handle all confidence levels (≥50%) - Increase resolvable suggestion limit from 5 to 8 - Add fallback handling for failed inline comments - Simplify summary comment to avoid duplication with inline comments - Standardize line_number field handling across services - Add helper methods: getConfidenceLabel(), inferLineNumber() - Update tests to match new inline comment behavior Benefits: - Better UX: suggestions appear exactly where they belong in code - Contextual feedback: reviewers see suggestions while reading relevant code - Uses GitHub's native inline comment and resolvable suggestion features - Reduces noise from giant comment blocks - Maintains all existing functionality with robust fallbacks 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🔒 Security Scan Results🚨 npm audit - Vulnerable Dependencies (3 found)
|
github-actions
Bot
added
the
ai-fix-security
The 'on' keyword should not be quoted in YAML workflow files. This was causing GitHub Actions to incorrectly trigger the emergency-controls workflow on push events instead of only on manual workflow_dispatch.
Add explicit check for workflow_dispatch event type to ensure emergency controls only run when manually triggered, never on push or pull_request events.
- Remove invalid use of env context in timeout-minutes (not available at job level) - Use hardcoded value of 10 minutes instead of fromJSON(env.EMERGENCY_TIMEOUT_MINUTES) - Remove unused env section from workflow file Fixes GitHub Actions error: 'Unrecognized named-value: env' in timeout-minutes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the AI review system to post comments inline to the actual files and lines where issues are found, instead of posting one giant comment with all suggestions.
Changes Made
postSuggestionsToGitHub()to post ALL suggestions as inline comments (not just high-confidence ones)generateAllInlineComments()method to handle all confidence levels (≥50%)line_numberfield handling across servicesgetConfidenceLabel(),inferLineNumber()Benefits
✅ Better UX: Suggestions appear exactly where they belong in the code
✅ Contextual feedback: Reviewers see suggestions while reading relevant code
✅ GitHub integration: Uses GitHub's native inline comment and resolvable suggestion features
✅ Reduced noise: No more giant comment blocks to scroll through
✅ Maintained functionality: All existing features still work with robust fallbacks
Before vs After
Before
After
Test Plan
Risk Assessment
Low Risk - The changes maintain backward compatibility and include robust fallback mechanisms. If inline comments fail, the system gracefully falls back to regular comments.
🤖 Generated with Claude Code