Fix flaky #1019
Closed
Fix flaky #1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Owner
|
Closing due to no files changed for this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[INCOMPLETE PR]
What is the purpose of this PR
This PR fixes the flaky test in JSONObjectTest.
There is nondeterminism which causes inconsistent test results. This happens because of ___ value. Using ____may fix the issue.
Reproduce the test failure
Run the test using Non-Dex:
mvn clean installmvn clean test edu.illinois:nondex-maven-plugin:2.1.1:nondexor
mvn clean installmvn test edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=org.json.junit.JSONObjectTest.valueToStringExpected result
The
JSONObjectTestpasses without NonDex shuffling.The
JSONObjectTestpasses with NonDex shuffling.Actual result
The
JSONObjectTestpasses without NonDex shuffling.The
JSONObjectTestfails with NonDex shuffling.Why the test fails
The
insert issuedoesinsert issueincorrectly so it accesses data in a non-deterministic way..
Fix
For the test, we changed _____ to fix the error regarding non-deterministism.