Skip to content

Conversation

@marilynel
Copy link
Contributor

Fixes #986

Made keepStrings account for null in XML; fixing regression from previous commit.
Refactored two XML tests to include null.
Unit tests ran with gradlew.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2025

@stleary stleary changed the title Fixed: <t>null</t> used to be {"t":"null"} but now its {"t":null} with useStrings Fix regression XML parsing null with keepStrings Jul 7, 2025
@stleary
Copy link
Owner

stleary commented Jul 7, 2025

What problem does this code solve?
Fixes a regression in XML parsing where null strings are not handled correctly when keepStrings is set

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, new unit tests were added

Was any code refactored in this commit?
XML null value testing was updated

Review status
APPROVED

Starting 3-day comment window

@stleary stleary merged commit f0a78af into stleary:master Jul 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression XML parsing null with keepStrings

2 participants