Skip to content

Conversation

@marilynel
Copy link
Contributor

@marilynel marilynel commented Jul 13, 2025

#980

Addressed strict mode issues with boolean and null casing in values, and boolean, null, and number as keys.

@sonarqubecloud
Copy link

@stleary stleary changed the title fixed some strict mode issues 980 fixed some strict mode issues Jul 14, 2025
@stleary
Copy link
Owner

stleary commented Jul 14, 2025

What problem does this code solve?
Fixes problems where Strict mode was not enforcing case for non-string values, and allowing non-string keys.

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, new unit tests were added

Was any code refactored in this commit?
No. Sonarqube found some minor issues. Submitter can fix them if time permits, otherwise I will fix them later.

Review status
APPROVED

Starting 3-day comment window

@stleary stleary merged commit 0a9364e into stleary:master Jul 17, 2025
8 checks passed
@stleary stleary mentioned this pull request Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants