feat: converted circleci workflows to gha #2840
Conversation
✅ Deploy Preview for stoplight-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stoplight-elements-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| on: | ||
| schedule: | ||
| - cron: 0 3 * * 1 | ||
| # # 'filters' was not transformed because there is no suitable equivalent in GitHub Actions |
There was a problem hiding this comment.
why is this comment here? i'm assuming this was just run through an llm, but what do we lose/gain by not using the filters from circle ci?
There was a problem hiding this comment.
This was run through a github actions importer tool from microsoft. The filters I believe were to enforce semver on the tags. I can fix that I found a solution using github filters.
There was a problem hiding this comment.
I looked at the orginal config file this is the original filters code:
filters:
branches:
only:
- main
Scheduled jobs run only on the last commit of the default branch so a filter shouldn't be needed.
| - name: Example - use local builds | ||
| run: yarn copy:${{ env.example-name }} | ||
| working-directory: "/mnt/ramdisk/project" | ||
| - name: Example - Install dependencies |
There was a problem hiding this comment.
why are the names sometimes Example - and sometimes not?
There was a problem hiding this comment.
This is from the tool I used. I am cross referencing everything the tool did versus the circleci config file. I review this more before I merge.
Elements Default PR Template
In general, make sure you have: (check the boxes to acknowledge you've followed this template)
CONTRIBUTING.mdOther Available PR Templates:
CONTRIBUTING.md