Skip to content

fix(js): remove window.parent lookup #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2025
Merged

fix(js): remove window.parent lookup #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0e47fa
fix(js): remove window.parent lookup
imranolas Jul 3, 2025
030486f
test(index): remove deprecated warning test
imranolas Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/js/src/bridge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,6 @@ export const loadBridge = (src: string) => {

// Way to make sure all event handlers are called after loading
window.storyblokRegisterEvent = (cb: () => void) => {
if (window.location === window.parent.location) {
console.warn('You are not in Draft Mode or in the Visual Editor.');
return;
}

if (!loaded) {
callbacks.push(cb);
}
Expand Down
19 changes: 0 additions & 19 deletions packages/js/src/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,25 +395,6 @@ describe('@storyblok/js', () => {
window.location = originalLocation;
});

it('should warn when not in editor mode', () => {
const consoleSpy = vi.spyOn(console, 'warn');
const callback = vi.fn();

// Ensure we're not in an iframe
Object.defineProperty(window, 'parent', {
value: { location: window.location },
writable: true,
});

loadBridge('https://app.storyblok.com/f/storyblok-v2-latest.js');
window.storyblokRegisterEvent(callback);

expect(consoleSpy).toHaveBeenCalledWith(
'You are not in Draft Mode or in the Visual Editor.',
);
expect(callback).not.toHaveBeenCalled();
});

it('should execute callbacks in order of registration', async () => {
const executionOrder: number[] = [];
const callback1 = vi.fn(() => executionOrder.push(1));
Expand Down