-
Notifications
You must be signed in to change notification settings - Fork 16
feat: cli-config-file #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
non-availability early
@storyblok/astro
storyblok
@storyblok/eslint-config
@storyblok/js
storyblok-js-client
@storyblok/management-api-client
@storyblok/nuxt
@storyblok/react
@storyblok/region-helper
@storyblok/richtext
@storyblok/svelte
@storyblok/vue
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| .command(commands.USER) | ||
| .description('Get the current user') | ||
| .option('--sf, --separate-files', 'Argument to create a single file for each component') | ||
| .option('--su, --suffix <suffix>', 'suffix to add to the file name (e.g. components.<suffix>.json)') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Misplaced Options in User Command Suite
The user command incorrectly includes --separate-files and --suffix options that are meant for components/datasources pull commands. These options reference creating files for components and have no relevance to the user command, which only fetches and displays user information without creating any files.
|
Feature is ready for review. Here's a few notes to hopefully help review. Manual Review NotesUse this checklist when reviewing the PR to make sure the new config behaviour work as expected. 1. Config Layering
2. Config vs CLI Overrides
3. Environment Variable Support
4. Config Format Coverage
5. Regression Smoke Tests
|
# Conflicts: # packages/cli/src/commands/types/generate/index.ts # pnpm-lock.yaml
DRAFT of discovery phase
WDX-181
Note
Introduces a first-class CLI configuration file (defineConfig) that’s resolved at runtime and applied to commands, with global options, defaults, and integration across fetch and filesystem utilities.
defineConfigAPI and config types (src/config/types.ts) withentrypoints/config.tsexport for user config.c12and pre-action hook; applies resolved config to Commander and sets global options.utils/fetchnow readsapi.maxRetriesfrom active config.DEFAULT_STORAGE_DIRand simplifyresolvePath(honor relative base path).utils/object(deep merge, isPlainObject, isEmptyObject); remove duplicate helper.dotenv/config; minor program bootstrap updates (getConfigDefaults).Written by Cursor Bugbot for commit 478ae14. This will update automatically on new commits. Configure here.