chore: remove implicit yarn dependency#21
Open
vitordino wants to merge 1 commit into
Open
Conversation
uses `npm run` for a more agnostic way of running (if you use yarn, it will use yarn anyway). this change also removes a implicit dependency. i’m a yarn person, but this was failing on some build machines — either using an older yarn version, or just using npm.
sibelius
approved these changes
Apr 13, 2021
yuritoledo
approved these changes
Apr 13, 2021
julioxavierr
approved these changes
Apr 16, 2021
Asim-Tahir
approved these changes
Jul 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uses
npm runfor a more agnostic way of running the scripts.this change also removes a implicit dependency.
i’m a yarn person, but this was failing on some build machines — either using an older yarn version, or just using npm — before even installing it.