Skip to content

Conversation

@poshinchen
Copy link
Contributor

@poshinchen poshinchen commented Nov 7, 2025

Description

Set use_latest_genai_conventions and include_tool_definitions to internal only.

Why making this change

As discussed in the thread, we wouldn't want users to adjust use_latest_genai_conventions and include_tool_definitions directly but setting the environment variables properly. Therefore adding the suffix _ and will update the documentation.

Breaking Change

User who sets tracer.use_latest_genai_conventions directly for latest semantic conventions will no longer work as it should be either _use_latest_genai_conventions or done it via environment variable.

Related Issues

#1083

Documentation PR

TBD

Type of Change

  • Chore update
  • Breaking change

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@poshinchen poshinchen requested a review from a team November 7, 2025 16:03
@github-actions github-actions bot added the size/s label Nov 7, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@poshinchen poshinchen marked this pull request as ready for review November 7, 2025 16:05
@pgrayy
Copy link
Member

pgrayy commented Nov 7, 2025

Can you add the reason for these changes to the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants