fix: pick up selfdestruct-refund balance fix from bnb-reth - #1
Merged
sduchesneau merged 2 commits intoAug 10, 2026
Merged
Conversation
Cargo.lock rev bump follows once streamingfast/bnb-reth#1 merges. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
sduchesneau
marked this pull request as ready for review
August 10, 2026 20:05
Author
|
battlefield passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the locked
streamingfast/bnb-rethrev to60d0672f(streamingfast/bnb-reth#1), which ports streamingfast/reth#22 (v2.3.0-fh-7) to that fork's vendoredcrates/firehose.On the truly-destroyed SELFDESTRUCT path (EIP-6780) revm credits the beneficiary in place and records the move only inside its
AccountDestroyedjournal entry — noBalanceTransfer— soresolve_post_tx_balancemissed it, and a coinbase or sender that received a suicide refund reported aRewardTransactionFee/GasRefundold_balancecontradicting theSuicideRefundevent emitted moments earlier.The
Cargo.lockdiff is exclusively the git rev on thebnb-rethsource (103source =lines, nothing else) —cargo update -p reth-firehoseadditionally downgraded unrelated transitive deps (itertools0.13/0.14 → 0.12.1,socket20.6.4 → 0.5.10), so the rev was applied surgically instead.cargo check --locked --bin reth-bscpasses and leaves the lock untouched.Validated with battlefield before the merge, building
reth-bscagainst the same tree: 82 passing, 3 pending, 0 failing onpnpm test:fh3.0:reth-bsc-dev, including all 9 Suicide cases.🤖 Generated with Claude Code