Repository navigation
Conversation
`bin/pulsar standalone` does not read the PULSAR_PREFIX_* variables, so none of the settings the workflow passes were actually applied.
Author
|
closing in favor of #428 which folds in this change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bin/pulsar standalonedoes not read thePULSAR_PREFIX_*variables, so none of the broker settings the workflow passes were actually applied. This worked because all of the env vars match the defaults.Also removes the
advertisedListenersenv var, which was invalid its prior form and the override is not needed anyway.