[ST] Initial Proxy setup and simple virtual kafka cluster test#2353
Open
jankalinic wants to merge 5 commits intostreamshub:mainfrom
Open
[ST] Initial Proxy setup and simple virtual kafka cluster test#2353jankalinic wants to merge 5 commits intostreamshub:mainfrom
jankalinic wants to merge 5 commits intostreamshub:mainfrom
Conversation
jankalinic
added
the
do not merge
Contributor
Author
|
/systemtests run --testcase=KroxyST --retry-count=1 |
Signed-off-by: jkalinic <jkalinic@redhat.com>
Signed-off-by: jkalinic <jkalinic@redhat.com> # Conflicts: # systemtests/src/main/java/com/github/streamshub/systemtests/constants/Labels.java
Signed-off-by: jkalinic <jkalinic@redhat.com>
|
Contributor
Author
|
/systemtests run --testcase=KroxyST --retry-count=0 |
✅ Systemtests run finished - success ✅Test Summary:
Used parameters:
|
jankalinic
added
ready for review
MikeEdgar
approved these changes
Mar 2, 2026
Comment on lines
+114
to
+117
| public static final String BOOTSTRAP_SERVERS = "bootstrap.servers"; | ||
| public static final String SECURITY_PROTOCOL = "security.protocol"; | ||
| public static final String SASL_MECHANISM = "sasl.mechanism"; | ||
| public static final String SASL_JAAS_CONFIG = "sasl.jaas.config"; |
Member
There was a problem hiding this comment.
FYI, these are defined in Kafka's CommonClientConfigs and SaslConfigs classes.
Contributor
Author
There was a problem hiding this comment.
Wonderful, thanks!
| import java.util.Optional; | ||
| import java.util.function.Consumer; | ||
|
|
||
| public class KafkaProtocolFilterType implements ResourceType<KafkaProtocolFilter> { |
Member
There was a problem hiding this comment.
Just a thought for a future PR - you can probably push most of this class and the others that extend ResourceType into an intermediate super-class with generics that accepts the Class<T> of the resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lays the ground for kroxylicous support and introduces an initial virtual Kafka cluster test scenario. The aim of this work is to start validating kroxy integration.
PR adds: