build(deps): bump shared-frontend to v3.0.39 + shared-core to v3.0.39 - #25
Merged
Conversation
Combines the valid scope of dependabot PRs #22 and #23: - frontend shared-frontend: v3.0.33 -> v3.0.39 - frontend shared-core: v3.0.33 -> v3.0.39 - backend shared-core: v3.0.33 -> v3.0.39 - backend shared-backend: v3.0.33 (preserved, not in scope of either PR) Regenerates Cargo.lock with both shared-core 3.0.33 (still required transitively by shared-backend 3.0.33) and the new shared-core 3.0.39. API surface used by rustle (shared_backend::{auth::PinState, auth::attempts, auth::session, middleware::cors_layer, server::ServerConfig, server::ip::get_client_ip, tracing_init::{init_tracing, default_log_dir}}; shared_core::i18n::Language; shared_frontend::{Header, Footer, detect_browser_locale, set_saved_locale}) is unchanged across v3.0.33..v3.0.39, so no source edits are required. Validated: - cargo check --workspace (exit 0) - cargo test --workspace (25 passed, 0 failed, 9 ignored)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Combines the valid scope of dependabot PRs #22 and #23 into a single dependency bump.
Changes
shared-backendstays atv3.0.33as instructed. It was not touched by either original PR, and keeping it pinned avoids unnecessary churn (shared-backend 3.0.34+ introduces API additions that rustle does not consume).Source impact
None. The rustle API surface consumed by
shared-*is unchanged acrossv3.0.33..v3.0.39:shared_backend::{auth::PinState, auth::attempts, auth::session, auth::read_pin_cookie, middleware::cors_layer, server::ServerConfig, server::ip::get_client_ip, tracing_init::{init_tracing, default_log_dir}}shared_core::i18n::Languageshared_frontend::{Header, Footer, detect_browser_locale, set_saved_locale}Cargo.lock
Regenerated via
cargo update --workspace. Result keeps bothshared-core 3.0.33(transitively required byshared-backend 3.0.33) and the newshared-core 3.0.39.Validation (local)
cargo check --workspace(debug) — exit 0, no warningscargo test --workspace— 25 passed, 0 failed, 9 ignoredutils::tests::test_get_holiday_for_date_*)shbin tests: 0#[ignore], require running container)cargo fmt --check,cargo clippy,cargo audit,cargo deny, and thewasm32-unknown-unknownbuild were NOT run locally (rustfmt/clippy/audit/deny are not installed in this environment, and the project pinsrust-toolchain = 1.96.0which only CI provides). CI will validate them on push.Files changed
backend/Cargo.toml(+1, -1)frontend/Cargo.toml(+2, -2)Cargo.lock(+15, -6)Tests
No new tests added. The dep bump does not introduce a real uncovered behavior in rustle (all consumed APIs already exist and were exercised before). Adding tests purely for the dep bump would be redundant dependency tests.
Notes
shared-backendintentionally remains atv3.0.33per the task scope.