qa(ui): add Playwright + axe UI/QA coverage - #27
Open
UberMetroid wants to merge 3 commits into
Open
Conversation
Replace the ad-hoc (unconstrained) rule set with a consistent policy
across the UI/QA suite:
* tag set : wcag2a + wcag2aa + wcag21aa + best-practice
(most restrictive reasonable configuration; previously
used axe defaults, which include every rule)
* severity : critical / serious -> hard failure
moderate / minor -> warning only (logged +
test annotation; does not fail the suite)
* disabled : color-contrast (dark-theme palette surfaces fall
below the 3:1 minimum required by WCAG 1.4.11),
region (single-board shell whose root is a <div> for
the grid; axe flags content not wrapped in landmark
elements; documented inline at the top of the spec)
Each spec now leads with a header block listing disabled rules and
rationale, so future contributors can re-enable a rule with the
threshold it must meet.
Collaborator
Author
qa(ui): tighten accessibility rules to most-restrictive axe tag setNew commit on Policy
Per-repo details (disabled rules, rationale, behavioural change vs. previous version) are in the commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds end-to-end, accessibility, and visual-regression coverage for rustle under
tests/ui/. The suite is decoupled from the Cargo build: it targets the already-built rustle server at theSTUDIO_URLenv var (defaults tohttp://127.0.0.1:4502) and can be pointed at any reachable instance.Stack
1.50.1(Chromium project only)@axe-core/playwright4.10.2Tests (20 across 7 files)
tests/root.spec.ts— root page render,<html lang>, head wiring, raw HTTP smoketests/pwa-manifest.spec.ts—/assets/manifest.jsonshape,<link rel="manifest">, iconstests/service-worker.spec.ts—/assets/service-worker.jscontent + browser registrationtests/pin-verify.spec.ts—/api/pin-required, happy path, wrong path, UI form (auto-skips when no PIN is configured)tests/game-round.spec.ts— full round: clickA P P L Eon the on-screen keyboard, observe tile states, verify keyboard feedbacktests/accessibility.spec.ts— axe scans on root and#game-grid, keyboard reachabilitytests/visual-grid.spec.ts— full-page screenshot of the starting grid as a baselineCI
.github/workflows/qa-ui.ymlbuilds the same Alpine image (Containerfile) used by production, runs it onlocalhost:4502withRUSTLE_PIN=1234, then runs the Playwright suite against it. Uploadsplaywright-report/+test-results/as artifacts on failure.What this PR does not change
tests/ui/+ one new workflow file.See
tests/ui/README.mdfor layout, env vars, snapshot regeneration, and known limitations.Verification
npm installcompletes (10 packages).npx playwright install chromiumsucceeds (Fedora 44 -> Chromium 1155 fallback build).npx tsc --noEmitexits 0.npx playwright test --listenumerates all 20 tests.