Update QR Scanner Implementation#181
Closed
dlynch-sublime wants to merge 0 commit into
Closed
Conversation
dlynch-sublime
force-pushed
the
dlynch-update-scan-qr
branch
from
a419dcb to
220e65c
Compare
dlynch-sublime
force-pushed
the
dlynch-update-scan-qr
branch
from
9474af3 to
f356129
Compare
dlynch-sublime
force-pushed
the
dlynch-update-scan-qr
branch
from
bce3eb1 to
220e65c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the change
https://sublimesecurity.slack.com/archives/C0ANY9PHXBK/p1779401530199849
Our existing QR Scanner implementation used pyzbar (similar to our old hydra implementation for beta.scan_qr). With the success of replacing pyzbar with a new pipeline leveraging zxing-cpp and WeChat CNN, this PR replicates that behavior in our QR Scanner implementation.
Describe testing procedures
Added new 'standalone' testing that leverages local test artifacts to confirm we successfully decode the qr codes that we were previously missing. These tests were run manually, with instructions included in the README on how to run these tests.