Update QR Scanner Implementation#182
Merged
Merged
Conversation
dlynch-sublime
changed the title
dlynch-sublime
force-pushed
the
dlynch-update-scan-qr
branch
from
3459d70 to
220e65c
Compare
dlynch-sublime
changed the title
dlynch-sublime
changed the title
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
raymolin-sublime
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the change
https://sublimesecurity.slack.com/archives/C0ANY9PHXBK/p1779401530199849
This updates our existing QR Scanner implementation to a more efficient approach that doesn't leverage pyzbar. This new approach is more successful in finding QR codes that were being missed previously by the old scanner implementation.
As part of this change, I added local testing against a series of QR codes we've identified as known 'misses'. This testing isn't included in the PR but is run locally to validate this approach.
Describe testing procedures
Implemented new 'standalone' testing that leverages existing test artifacts we use for our internal scanning implementation. These tests were run manually locally against the new scanner implementation to validate that the approach finds the qr codes we were previously missing.