[Python] Unify block begin punctuation #4413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit scopes all colons `punctuation.section.block.begin`, which start an indented block of code, regardless their actual context. The point is colon indicating a start of a code block, like an opening brace in a C-style language. We just don't scope the block `meta.block` as we don't want or can't reliably count indentation to pop it off, correctly.
keith-hall
approved these changes
Dec 10, 2025
Collaborator
keith-hall
left a comment
keith-hall
left a comment
There was a problem hiding this comment.
I used to have separate color scheme rules for punctuation of various block types, but probably it makes sense to unify
Collaborator
Author
|
Exactly, what I wouldn't have expected anyone to do :-D FWIW, most of them are covered by corresponding meta scopes, if distinct colors is desired. |
michaelblyons
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit scopes all colons
punctuation.section.block.begin, which start an indented block of code, regardless their actual context.The point is colon indicating a start of a code block, like an opening brace in a C-style language. We just don't scope the block
meta.blockas we don't want or can't reliably count indentation to pop it off, correctly.