Skip to content

fix: remove SHELL from devcontainer #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nielspardon merged 2 commits into from
Oct 27, 2025
Merged

fix: remove SHELL from devcontainer #116

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dbeadc
fix: remove SHELL from devcontainer
tokoko Oct 25, 2025
5856107
Update .devcontainer/Dockerfile
tokoko Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
FROM mcr.microsoft.com/vscode/devcontainers/python:3.13
USER vscode
RUN curl -s "https://get.sdkman.io" | bash
SHELL ["/bin/bash", "-c"]
RUN source "/home/vscode/.sdkman/bin/sdkman-init.sh" && sdk install java 25-graalce
RUN bash -c "source $HOME/.sdkman/bin/sdkman-init.sh && \
sdk install java 25-graalce"
RUN mkdir -p ~/lib && cd ~/lib && curl -L -O http://www.antlr.org/download/antlr-4.13.2-complete.jar
ENV ANTLR_JAR="~/lib/antlr-4.13.1-complete.jar"
# protoc 29.5 is the last version with protobuf python v5 which is compatible with protoletariat v3
Expand Down
3 changes: 1 addition & 2 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
"name": "substrait-python-devcontainer",
"build": {
"context": "..",
"dockerfile": "Dockerfile",
"options": ["--format=docker"]
"dockerfile": "Dockerfile"
},

// Features to add to the dev container. More info: https://containers.dev/features.
Expand Down