feat(types): add comprehensive type support and stricter validation #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Add wide-ranging support for additional scalar and parameterized Substrait types, improve parameter handling, and make nullability/precision checks stricter and more correct. Signed-off-by: MBWhite <[email protected]>
tokoko
reviewed
Dec 8, 2025
tokoko
reviewed
Dec 8, 2025
tokoko
reviewed
Dec 8, 2025
Contributor
Author
|
tokoko
reviewed
Dec 8, 2025
tokoko
approved these changes
Dec 8, 2025
Contributor
tokoko
left a comment
tokoko
left a comment
There was a problem hiding this comment.
left a couple comments, but looks good to me. this is great, thanks.
Member
bestbeforetoday
left a comment
bestbeforetoday
left a comment
There was a problem hiding this comment.
Content looks good to me. Like tokoko, just one query/suggestion on code clarity (see inline comment). It's not a show-stopper though. If you want to change what is there, please go ahead. If not, just say and I think it could be merged as-is.
Contributor
Author
|
I've refactor the code as you suggested @bestbeforetoday |
bestbeforetoday
approved these changes
Dec 10, 2025
Member
bestbeforetoday
left a comment
bestbeforetoday
left a comment
There was a problem hiding this comment.
Thank you for the updates. That looks much clearer to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded type support with new scalar and parameterized types.
Improved parameter validation and stricter nullability/precision checks.