Skip to content

[WIP] max recipient quota #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sdemagny wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[WIP] max recipient quota #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e2ceea0
✨(recipients) handle MAX_RECIPIENTS_PER_MESSAGE
sdemagny Dec 15, 2025
67c1b29
remove as any
sdemagny Dec 15, 2025
2169aab
fix test
sdemagny Dec 15, 2025
4f66ec2
lint
sdemagny Dec 18, 2025
1cd50e7
MAX_RECIPIENTS and quota management
sdemagny Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,28 @@ services:
ports:
- "8913:6379"

redis-quotas:
Copy link
Member

@sylvinus sylvinus Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have a redis server, let's reuse it

image: redis:7-alpine
command: >
redis-server
--port 6380
--maxmemory-policy noeviction
--appendonly yes
--appendfsync everysec
--save 900 1
--save 300 10
--save 60 10000
ports:
- "8916:6380"
volumes:
- redis-quotas-data:/data
healthcheck:
test: ["CMD", "redis-cli", "-p", "6380", "ping"]
interval: 5s
timeout: 3s
retries: 5
restart: unless-stopped
Comment on lines +22 to +42
Copy link

@coderabbitai coderabbitai bot Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Port conflict: redis-quotas and socks-proxy both use host port 8916.

Line 334 maps socks-proxy to 8916:1080 and line 34 maps redis-quotas to 8916:6380. This creates a port conflict where only one service can bind to host port 8916, causing the other to fail.

🔎 Apply this diff to resolve the port conflict: 
     ports:
-      - "8916:6380"
+      - "8918:6380"

Note: Choose an available port number that doesn't conflict with existing services.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
redis-quotas:
image: redis:7-alpine
command: >
redis-server
--port 6380
--maxmemory-policy noeviction
--appendonly yes
--appendfsync everysec
--save 900 1
--save 300 10
--save 60 10000
ports:
- "8916:6380"
volumes:
- redis-quotas-data:/data
healthcheck:
test: ["CMD", "redis-cli", "-p", "6380", "ping"]
interval: 5s
timeout: 3s
retries: 5
restart: unless-stopped
redis-quotas:
image: redis:7-alpine
command: >
redis-server
--port 6380
--maxmemory-policy noeviction
--appendonly yes
--appendfsync everysec
--save 900 1
--save 300 10
--save 60 10000
ports:
- "8918:6380"
volumes:
- redis-quotas-data:/data
healthcheck:
test: ["CMD", "redis-cli", "-p", "6380", "ping"]
interval: 5s
timeout: 3s
retries: 5
restart: unless-stopped
🤖 Prompt for AI Agents 
In compose.yaml around lines 22 to 42 there is a host port conflict:
redis-quotas maps host port 8916:6380 while socks-proxy also maps host port
8916:1080 (line ~334), so only one can bind. Fix by changing one service's host
port to an unused port (for example change redis-quotas or socks-proxy host side
from 8916 to an available port like 8917 or another free port), update any docs
or consumer configs that expect the old host port, and ensure the chosen port
does not collide with other services.


opensearch:
image: opensearchproject/opensearch:2.19.2
environment:
Expand Down Expand Up @@ -355,3 +377,7 @@ services:
- "8902:8802"
depends_on:
- postgresql

volumes:
redis-quotas-data:
driver: local
4 changes: 4 additions & 0 deletions env.d/development/backend.e2e
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,7 @@ EMAIL_BACKEND=django.core.mail.backends.console.EmailBackend

# Debug
DJANGO_DEBUG=True

# Max recipients per message settings for E2E tests
MAX_RECIPIENTS_PER_MESSAGE=200
MAX_DEFAULT_RECIPIENTS_PER_MESSAGE=150
Loading