Skip to content

Conversation

@samrose
Copy link
Collaborator

@samrose samrose commented Nov 17, 2025

Reduced the closure size (total dependency footprint) of the plv8 PostgreSQL extension by optimizing its runtime dependencies.

What was changed:

  1. nix/ext/plv8/default.nix - Replaced stdenv.cc.cc.lib with libcxx in all rpath settings
    - Added libcxx to the function inputs
    - Updated 4 locations where runtime library paths are set (both Darwin/macOS and Linux paths)
    - This reduces closure size because stdenv.cc.cc.lib pulls in the entire compiler toolchain, while libcxx only brings in the C++ standard library

@samrose samrose requested review from a team as code owners November 17, 2025 19:41
Copy link
Contributor

@jchancojr jchancojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ty so much

@hunleyd hunleyd added this pull request to the merge queue Nov 18, 2025
Merged via the queue into develop with commit 7c2878c Nov 18, 2025
28 checks passed
@hunleyd hunleyd deleted the pg-15-closure-plv8 branch November 18, 2025 15:43
hunleyd added a commit that referenced this pull request Nov 18, 2025
* 'develop' of github.com:supabase/postgres:
  feat: reduciton of closure size for plv8 (#1925)
hunleyd added a commit that referenced this pull request Nov 18, 2025
* 'develop' of github.com:supabase/postgres:
  feat: reduciton of closure size for plv8 (#1925)
hunleyd added a commit that referenced this pull request Dec 1, 2025
* origin/develop:
  chore: bump Wrappers version to 0.5.7 (#1945)
  chore: bump versions (#1949)
  Revert "docs: create an automated changlog file that shows up in release file…" (#1948)
  chore: remove precreated Storage objects (#1911)
  refactor: Move PostgreSQL auto_explain config to conf.d (#1943)
  docs: create an automated changlog file that shows up in release files (#1793)
  fix: removing dead nix code (#1946)
  docs: expansion to help understand anatomy and code api in user here (#1944)
  fix: try to use mirror fallbacks for docker images (#1942)
  feat: need this workflow present to test (#1941)
  feat: Add PostgreSQL conf.d directory (#1929)
  [jj-spr] initial version (#1866)
  chore: upgrade supabase-admin-agent (#1935)
  fix: garbage collect after every profile intall + remove osquery (#1938)
  fix(ci): limit max-jobs of nix to 8 to prevent OOM while running nix flake check (#1933)
  Revert "fix: disable temporary Nix checks on aarch64-linux" (#1934)
  fix: adaptive retry on aws (#1917)
  fix: disable temporary Nix checks on aarch64-linux (#1930)
  feat: release orioledb with rewind functionality (#1880)
  feat: reduciton of closure size for plv8 (#1925)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants