Skip to content

Fix session timeout check with -t tokens #4759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Roadmaster wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix session timeout check with -t tokens #4759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions internal/command/command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,11 +566,13 @@ func RequireSession(ctx context.Context) (context.Context, error) {
return handleReLogin(ctx, "not_authenticated")
}

// Skip timestamp validation if token is from environment variable (CI/CD use case)
// This allows automated pipelines to continue working without session timeout
tokenFromEnv := env.First(config.AccessTokenEnvKey, config.APITokenEnvKey) != ""
// Skip timestamp validation if token is explicitly provided via environment
// variable or -t flag (CI/CD and scripted use cases).
// This allows automated pipelines to continue working without session timeout.
tokenExplicit := env.First(config.AccessTokenEnvKey, config.APITokenEnvKey) != "" ||
flag.IsSpecified(ctx, "access-token")

if !tokenFromEnv {
if !tokenExplicit {
// Check if the token has expired due to age
// If LastLogin is zero, it means the user has an old config without the timestamp
if cfg.LastLogin.IsZero() {
Expand Down
Loading