Extract status logging functions to eliminate duplication#4838
Open
khushal-winner wants to merge 1 commit intosuperfly:masterfrom
Open
Extract status logging functions to eliminate duplication#4838khushal-winner wants to merge 1 commit intosuperfly:masterfrom
khushal-winner wants to merge 1 commit intosuperfly:masterfrom
Conversation
- Add 7 helper functions (28 LOC) for status logging patterns - Replace 23 duplicate logging patterns with helper functions - Eliminates repetition while maintaining identical output - Improves maintainability with single source of truth for logging Helper functions: - logMachineActionRunning/Success/Failure - logLeaseActionRunning/Success/Failure - logMachineStatus Replaced patterns: - Phase A: 9 lease acquisition/clearing patterns - Phase B: 4 machine state/failure patterns - Phase C: 10 machine action patterns Signed-off-by: Khushal Malhotra <redmi5a3217@gmail.com>
Author
|
@dangra , hi maintainers could u please take a review of these helper functions & I am open to do any changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
Helper functions:
Replaced patterns:
How:
Related to:
Documentation