Skip to content

fix: guard approval details when records metadata is missing - #6871

Open
advien wants to merge 1 commit into
superplanehq:mainfrom
advien:fix/guard-missing-approval-records
Open

advien wants to merge 1 commit into
superplanehq:mainfrom
advien:fix/guard-missing-approval-records

Conversation

@advien

@advien advien commented Aug 24, 2026

Copy link
Copy Markdown

What changed
This PR guards the approval mapper when execution metadata exists but records is missing.

Why
Approval execution metadata can be partially incomplete, and the UI should still show basic execution details instead of crashing.

How

  • return base execution details when metadata.records is missing
  • add a focused regression test for that edge case

@superplanehq-integration

Copy link
Copy Markdown
Contributor

👋 Commands for maintainers:

  • /sp start - Start an ephemeral machine (takes ~30s)
  • /sp stop - Stop a running machine (auto-executed on pr close)

@superplanehq-integration

Copy link
Copy Markdown
Contributor

Maintainers: comment /deploy-storybook to get a Storybook link for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant