Skip to content

Conversation

@mrandrewsmith
Copy link
Contributor

The problem

builder.add(provider: provider) was ignored for multipart requests

What is done

  • Added header providers for multipart request
  • Created tests for new functionality

@mrandrewsmith mrandrewsmith self-assigned this Dec 25, 2024
@mrandrewsmith mrandrewsmith changed the base branch from master to update-xcresultparser December 25, 2024 13:45
@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.26%. Comparing base (1aaa23c) to head (fda636e).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
NodeKit/NodeKit/Chains/ServiceChainProvider.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   92.23%   93.26%   +1.03%     
==========================================
  Files          85       85              
  Lines        1326     1826     +500     
==========================================
+ Hits         1223     1703     +480     
- Misses        103      123      +20     
Flag Coverage Δ
tests 93.26% <81.81%> (+1.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

NullIsOne
NullIsOne previously approved these changes Jan 13, 2025
@mrandrewsmith mrandrewsmith changed the base branch from update-xcresultparser to master January 27, 2025 10:28
@mrandrewsmith mrandrewsmith dismissed NullIsOne’s stale review January 27, 2025 10:28

The base branch was changed.

@mrandrewsmith mrandrewsmith merged commit 8cfe9d6 into master Jan 27, 2025
2 of 3 checks passed
@mrandrewsmith mrandrewsmith deleted the fix-multipart-from-data branch January 27, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants