Changes skill APIs

insthync · insthync · commit 97cd1975031e · 2021-06-21T15:56:29.000+07:00
diff --git a/Scripts/AimAtCursorPlayerCharacterController.cs b/Scripts/AimAtCursorPlayerCharacterController.cs
@@ -442,7 +442,7 @@ protected void UseSkill(string id, AimPosition aimPosition)
                 !PlayerCharacterEntity.GetCaches().Skills.TryGetValue(skill, out _))
                 return;
 
-            bool isAttackSkill = skill.IsAttack();
+            bool isAttackSkill = skill.IsAttack;
             if (PlayerCharacterEntity.UseSkill(skill.DataId, isLeftHandAttacking, SelectedEntityObjectId, aimPosition) && isAttackSkill)
             {
                 isLeftHandAttacking = !isLeftHandAttacking;
@@ -499,7 +499,7 @@ protected void UseItem(string id, AimPosition aimPosition)
             }
             else if (item.IsSkill())
             {
-                bool isAttackSkill = (item as ISkillItem).UsingSkill.IsAttack();
+                bool isAttackSkill = (item as ISkillItem).UsingSkill.IsAttack;
                 if (PlayerCharacterEntity.UseSkillItem((short)itemIndex, isLeftHandAttacking, SelectedEntityObjectId, aimPosition) && isAttackSkill)
                 {
                     isLeftHandAttacking = !isLeftHandAttacking;

Original file line number	Diff line number	Diff line change
`@@ -442,7 +442,7 @@ protected void UseSkill(string id, AimPosition aimPosition)`
`442`	`442`	`!PlayerCharacterEntity.GetCaches().Skills.TryGetValue(skill, out _))`
`443`	`443`	`return;`
`444`	`444`
`445`		`- bool isAttackSkill = skill.IsAttack();`
	`445`	`+ bool isAttackSkill = skill.IsAttack;`
`446`	`446`	`if (PlayerCharacterEntity.UseSkill(skill.DataId, isLeftHandAttacking, SelectedEntityObjectId, aimPosition) && isAttackSkill)`
`447`	`447`	`{`
`448`	`448`	`isLeftHandAttacking = !isLeftHandAttacking;`
`@@ -499,7 +499,7 @@ protected void UseItem(string id, AimPosition aimPosition)`
`499`	`499`	`}`
`500`	`500`	`else if (item.IsSkill())`
`501`	`501`	`{`
`502`		`- bool isAttackSkill = (item as ISkillItem).UsingSkill.IsAttack();`
	`502`	`+ bool isAttackSkill = (item as ISkillItem).UsingSkill.IsAttack;`
`503`	`503`	`if (PlayerCharacterEntity.UseSkillItem((short)itemIndex, isLeftHandAttacking, SelectedEntityObjectId, aimPosition) && isAttackSkill)`
`504`	`504`	`{`
`505`	`505`	`isLeftHandAttacking = !isLeftHandAttacking;`