Repository navigation
fix: normalize route dependency scan globs on Windows - #17680
Draft
svelte-triage-bot[bot] wants to merge 1 commit into
Draft
svelte-triage-bot[bot] wants to merge 1 commit into
svelte-triage-bot[bot] wants to merge 1 commit into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/2236559e916e64a2a5a172dda34596cf823311b7Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 2236559 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17679
Kit interpolates native absolute route directory paths into Vite's glob-based dependency scanner. On Windows, backslashes are interpreted as escapes rather than separators, so no routes are scanned and route-only dependencies are discovered lazily.
Route entries were introduced in #12182 to eagerly discover dependencies from configurable route files. #12242 added the server-file exclusion. Although #17247 removed the obsolete build-input workaround, explicit route scanning remains necessary for Kit's non-HTML-entry development setup.
Normalize the directory prefix in both the positive and negative patterns using the existing
posixifyhelper. Keeping the conversion at the glob boundary leaves native filesystem paths elsewhere unchanged and preserves absolute custom route locations, the existing filename patterns, server-only exclusions, and user-entry merging. Globally normalizing configuration paths or switching to root-relative entries would broaden the change unnecessarily.The regression exercises Windows separators on any platform and isolates its generated manifest from the running test app.