Skip to content

fix invalid negative values in sourcemap column indexes #17167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix invalid negative values in sourcemap column indexes #17167

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c3e276
add check for negative idx to sourcemaps test
dominikg Nov 17, 2025
cc9219a
fix: format
dominikg Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/svelte/tests/sourcemaps/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,20 @@ const { test, run } = suite<SourcemapTest>(async (config, cwd) => {

const decoded = decode(map.mappings);

/*
Decoded sourcemap mappings contain absolute line/column numbers.
Negative values are invalid and can cause errors in downstream processing
*/
for (let l = 0; l < decoded.length; l++) {
for (let m of decoded[l]) {
if (m.find((i) => i < 0)) {
throw new Error(
`Invalid mapping with negative value ${JSON.stringify(m)} at line ${l} of the decoded mappings of ${info} sourcemap\n${JSON.stringify(map)}`
);
}
}
}

try {
for (let entry of entries) {
entry = typeof entry === 'string' ? { str: entry } : entry;
Expand Down
Loading