Add new ValueVec a list mutable from the minijinja context
#143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-mman
force-pushed
the
mendy/add-mut-list
branch
from
1f99ef8 to
7d1829d
Compare
svix-mman
changed the base branch from
mendy/add-new-frontmatter-parser
to
main
svix-mman
force-pushed
the
mendy/add-mut-list
branch
2 times, most recently
from
34e301a to
efad6a0
Compare
svix-jplatte
reviewed
Dec 5, 2025
Member
There was a problem hiding this comment.
May I suggest renaming the Rust struct to ValueVec or Array, the constructor to vec() or array() (akin to dict(), namespace()) and the method to push?
svix-mman
force-pushed
the
mendy/add-mut-list
branch
from
efad6a0 to
9874c2e
Compare
svix-jplatte
changed the title
MutList a list mutable from the minijinja contextValueVec a list mutable from the minijinja context
svix-jplatte
approved these changes
Dec 5, 2025
Member
svix-jplatte
left a comment
svix-jplatte
left a comment
There was a problem hiding this comment.
Make sure to squash-merge and adjust the message to mention the right name 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MutListwill help with the upcoming v2 CLI.It's has a simple
appendmethod, and it implementsenumerateso I will be able to iterate through the vec from within a template.