Skip to content

Install SourceKit-LSP configuration schema into toolchain at share/sourcekit-lsp/config.schema.json #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Install SourceKit-LSP configuration schema into toolchain at share/sourcekit-lsp/config.schema.json #2147

wants to merge 2 commits into from

Conversation

@ahoppen
Copy link
Member

@ahoppen ahoppen commented May 12, 2025

This allows IDEs like VS Code to pick up the schema and provide code assistance when editing .sourcekit-lsp/config.json.

@ahoppen
Install SourceKit-LSP configuration schema into toolchain at `share/s…
47c2d98 
…ourcekit-lsp/config.schema.json`

This allows IDEs like VS Code to pick up the schema and provide code assistance when editing `.sourcekit-lsp/config.json`.
@ahoppen ahoppen requested review from bnbarham and hamishknight May 12, 2025 14:26
@ahoppen
Copy link
Member Author

ahoppen commented May 12, 2025

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented May 13, 2025

@swift-ci Please test macOS

@bnbarham bnbarham mentioned this pull request Nov 19, 2025
Closed
compnerd
compnerd reviewed Nov 19, 2025
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add an install rule in the CMake build for this as well?

@ahoppen
Copy link
Member Author

ahoppen commented Nov 19, 2025

That’s the reason why the PR hasn’t been merged for half a year 😉

@bnbarham
Copy link
Contributor

bnbarham commented Nov 19, 2025 •
edited
Loading

That comment was in response to me putting up a build.ps1 change instead of the cmake like I should have :) I'll put that up here

@bnbarham bnbarham requested a review from rintaro as a code owner November 22, 2025 02:56
@bnbarham
Copy link
Contributor

bnbarham commented Nov 22, 2025 

PS C:\Users\bbarham\sourcekit-lsp> ls "S:/Program Files/Swift/Toolchains/0.0.0+Asserts/usr/share/sourcekit-lsp"

    Directory: S:\Program Files\Swift\Toolchains\0.0.0+Asserts\usr\share\sourcekit-lsp

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a----        11/18/2025   2:21 PM          17791 config.schema.json

@bnbarham bnbarham mentioned this pull request Nov 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compnerd compnerd compnerd left review comments

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahoppen @bnbarham @compnerd