🍒 [windows] add an option to install Embeddable Python 3.10.1 in the toolchain installer #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-zablit
requested review from
compnerd,
etcwilde and
shahmishal
as code owners
compnerd
reviewed
Nov 24, 2025
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Does this have to be a merge? Why is a cherry-pick not appropriate? Additionally, please cherry-pick my pending PR at the same time, I think that we shouldn't do this cherry-pick partially.
charles-zablit
force-pushed
the
charles-zablit/windows/embed-python-in-the-installer-to-release-6.2
branch
from
97c21b0 to
c44d9a4
Compare
charles-zablit
force-pushed
the
charles-zablit/windows/embed-python-in-the-installer-to-release-6.2
branch
from
c44d9a4 to
d2d01d9
Compare
compnerd
approved these changes
Nov 24, 2025
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
This change looks good to me; please do a cross-repo test before merging. Additionally, note that this requires a build.ps1 change that is also currently pending due to the current branch lock + pending review for the actual installer changes.
charles-zablit
force-pushed
the
charles-zablit/windows/embed-python-in-the-installer-to-release-6.2
branch
from
6205359 to
4f08b37
Compare
…olchain installer
Restructure the python installation to mimic the Unix style layout that we use throughout the components. Specifically, migrate the .exe and .dll files into a `/usr/bin` subdirectory under the installation and move the license into the package itself.
charles-zablit
force-pushed
the
charles-zablit/windows/embed-python-in-the-installer-to-release-6.2
branch
from
4f08b37 to
9bfd4e3
Compare
Contributor
Author
|
The changes above were intended for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.