Skip to content

Skip InterfaceWrapper generation for protocols with static requirements #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktoso merged 2 commits into from
Feb 9, 2026
Merged

Skip InterfaceWrapper generation for protocols with static requirements #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1c984e
JavaInterfaceProtocolWrapper also ignores static requirements
sidepelican Feb 9, 2026
e1629ac
Skip interface protocol generation except protocol
sidepelican Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion Samples/SwiftJavaExtractJNISampleApp/Sources/MySwiftLibrary/ProtocolWithStatic.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,19 @@
public protocol ProtocolWithStatic {
// static requirements are not yet supported.
static func myFunc() -> Int
static var value: Int64 { get }
init()
}

public func useProtocolWithStatic(_ value: any ProtocolWithStatic) -> Int {
let meta = type(of: value)
return meta.myFunc()
}

public protocol ProtocolWithStaticProperty {
static var value: Int { get }
}

public func useProtocolWithStaticProperty(_ value: any ProtocolWithStaticProperty) -> Int {
let meta = type(of: value)
return meta.value
}
8 changes: 7 additions & 1 deletion Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+InterfaceWrapperGeneration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ extension JNISwift2JavaGenerator {
) -> [ImportedNominalType: JavaInterfaceSwiftWrapper] {
var wrappers = [ImportedNominalType: JavaInterfaceSwiftWrapper]()

for type in types {
for type in types where type.swiftNominal.kind == .protocol {
Copy link
Contributor Author

@sidepelican sidepelican Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that JavaInterfaceProtocolWrapperGenerator was being used for all types erroneously.

Copy link
Collaborator

@ktoso ktoso Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, nice catch

do {
let translator = JavaInterfaceProtocolWrapperGenerator()
wrappers[type] = try translator.generate(for: type)
Expand Down Expand Up @@ -78,6 +78,12 @@ extension JNISwift2JavaGenerator {

struct JavaInterfaceProtocolWrapperGenerator {
func generate(for type: ImportedNominalType) throws -> JavaInterfaceSwiftWrapper {
if !type.initializers.isEmpty
|| type.methods.contains(where: \.isStatic)
|| type.variables.contains(where: \.isStatic) {
throw JavaTranslationError.protocolStaticRequirementsNotSupported
}

let functions = try type.methods.map { method in
try translate(function: method)
}
Expand Down
2 changes: 2 additions & 0 deletions Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaTranslation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1369,6 +1369,8 @@ extension JNISwift2JavaGenerator {
// FIXME: Remove once we support protocol variables
case protocolVariablesNotSupported

case protocolStaticRequirementsNotSupported

/// We cannot generate interface wrappers for
/// protocols that we unable to be jextracted.
case protocolWasNotExtracted
Expand Down
Loading