Capture code snippet from diagnostic compiler output #9362

bripeticca · 2025-11-11T17:13:25Z

This PR refactors diagnostic handling in the Swift build system by introducing a dedicated message handler and per-task output buffering to properly parse and emit compiler diagnostics individually.

Key Changes

SwiftBuildSystemMessageHandler

Introduced a new dedicated handler class to process SwiftBuildMessage events from the build operation
Moved message handling logic out of inline nested functions for better organization and testability
Maintains build state, progress animation, and diagnostic processing in a single cohesive component

Per-Task Data Buffering

Added taskBuffer: [String: Data] dictionary in BuildState to capture compiler output per task signature
Task output is accumulated in the buffer as .output messages arrive
Buffer contents are processed when tasks complete, ensuring all output is captured before parsing

Diagnostic Parsing & Emission

Implemented splitIntoDiagnostics() method that uses regex to parse compiler output into individual
diagnostic segments (ParsedDiagnostic)
Recognizes standard Swift diagnostic format: path:line:column: severity: message
To prevent duplication, we selectively emit DiagnosticInfo depending on whether the flag appendToOutputStream is true.
Each parsed diagnostic includes file location, severity, message text, and full context (code snippets,
carets, etc.)
Falls back to legacy emission behaviour when no structured diagnostics are found in output
Prevents duplicate emission by tracking processed task signatures

* Built tentative test class SwiftBuildSystemOutputParser to handle the compiler output specifically * Added a handleDiagnostic method to possibly substitute the emitEvent local scope implementation of handling a SwiftBuildMessage diagnostic

* the flag `appendToOutputStream` helps us to determine whether a diagnostic is to be emitted or whether we'll be emitting the compiler output via OutputInfo * separate the emitEvent method into the SwiftBuildSystemMessageHandler

Sources/SwiftBuildSupport/SwiftBuildSystem.swift

bripeticca · 2025-11-20T19:08:16Z

@swift-ci please test

owenv

Thie generally lgtm but I have some concerns about the regex-based parsing when we emit the textual compiler output.

Perf - It's important this is fast so that it doesn't block the end of the build if a command produces huge quantities of output. It's hard to say if this will be a real issue without some testing
We're re-parsing information which we're already getting from the compiler in structured form. I see the appeal of not reporting a diagnostic twice if multiple compile jobs report it though

owenv · 2025-11-20T23:02:46Z

Sources/SwiftBuildSupport/SwiftBuildSystem.swift

+            targetsByID[target.targetID] = target
+        }
+
+        mutating func target(for task: SwiftBuild.SwiftBuildMessage.TaskStartedInfo) throws -> SwiftBuild.SwiftBuildMessage.TargetStartedInfo? {


Does this need to be mutating?

It does not, will modify this

owenv · 2025-11-20T23:05:54Z

Sources/SwiftBuildSupport/SwiftBuildSystem.swift

+                    buildState.appendToBuffer(taskSignature, data: info.data)
+                }
+
+                return


If we're unable to get a taskID, this may be target/global output, so I think we should print it the best we can instead of returning and silently dropping it

Also suggested using a locationContext as the key, which might help.

It might be about time to clean up these deprecated APIs, too. I recall there was something missing from the new ones which blocked total removal.

owenv · 2025-11-20T23:08:13Z

Sources/SwiftBuildSupport/SwiftBuildSystem.swift

+
+            // If we've captured the compiler output with formatted diagnostics, emit them.
+//            if let buffer = buildState.dataBuffer(for: startedInfo) {
+            emitDiagnosticCompilerOutput(startedInfo)


This could be something other than a compile task which emits output with different formatting than we expect

Definitely. There are some guards in emitDiagnosticCompilerOutput that checks whether there is an existing data buffer that we've logged from the received SwiftBuildMessage.OutputInfo case so if this is anything else it will not be emitted.

Is it preferred to have this check be more explicit re: asserting this before calling this method?

jakepetroules · 2025-11-20T23:46:02Z

Sources/SwiftBuildSupport/SwiftBuildSystem.swift

+
+    /// Split compiler output into individual diagnostic segments
+    /// Format: /path/to/file.swift:line:column: severity: message
+    private func splitIntoDiagnostics(_ output: String) -> [ParsedDiagnostic] {


I don't think we should be doing any output parsing at this level, Swift Build already has an entire subsystem dedicated to doing this.

@jakepetroules I would agree, however the events we're receiving from SwiftBuild accumulates every diagnostic message into a singular data buffer -- when emitting this as-is, it's possible that we'd be coupling some info-level diagnostics with error-level diagnostics with no way to separate the severity. Splitting the string on a per-diagnostic basis is the only way to achieve this in this way.

The observability scope that we use to emit these diagnostics will capture the entire string blob, and we have to decide with what severity to emit the entire message. I'm not sure if there's an alternative path here that would give us the same ergonomics on the user front, but IMO it's preferred to separate each diagnostic and ensure that we're emitting them with the appropriate severity, rather than sending the entire string of possibly many diagnostics with varying severities.

jakepetroules · 2025-11-20T23:50:11Z

Sources/SwiftBuildSupport/SwiftBuildSystem.swift

+    struct BuildState {
+        private var targetsByID: [Int: SwiftBuild.SwiftBuildMessage.TargetStartedInfo] = [:]
+        private var activeTasks: [Int: SwiftBuild.SwiftBuildMessage.TaskStartedInfo] = [:]
+        private var taskBuffer: [String: Data] = [:]


Instead of a string as the key, can you use a SwiftBuildMessage.LocationContext?

jakepetroules · 2025-11-20T23:57:53Z

Sources/SwiftBuildSupport/SwiftBuildSystem.swift

+            buildSystem.delegate?.buildSystem(buildSystem, didFinishCommand: BuildSystemCommand(startedInfo, targetInfo: targetInfo))
+            if let targetName = targetInfo?.targetName {
+                serializedDiagnosticPathsByTargetName[targetName, default: []].append(contentsOf: startedInfo.serializedDiagnosticsPaths.compactMap {
+                    try? Basics.AbsolutePath(validating: $0.pathString)


Just let this throw, if this isn't an absolute path something has gone very wrong.

jakepetroules · 2025-11-21T00:03:08Z

Sources/SwiftBuildSupport/SwiftBuildSystem.swift

+                self.observabilityScope.emit(info: "\(info.executionDescription)")
+            }
+
+            if self.logLevel.isVerbose {


We should not write any output on task started events and instead always defer its emission to task completed events. The reason is that multiple tasks can start in parallel, and the outputStream content emitted when the taskStarted and taskEnded events are emitted may not be reasonably ordered at all. so you could have:

task 1 header

task 2 output

task 1 header

task 2 output

...which will be really confusing since task 2's output will look like it belongs to task 1, and so on.

The observabilityScope stuff might be OK, provided that doesn't also end up in the textual output stream and is only for API clients.

Thanks for the detailed explanation! I'm in agreement -- this is some legacy implementation that I moved from the inline method to this class, so it's possible that this kind of behaviour is sprinkled elsewhere in emitEvent. I'll keep an eye on that :)

jakepetroules · 2025-11-21T04:41:23Z

2. We're re-parsing information which we're already getting from the compiler in structured form. I see the appeal of not reporting a diagnostic twice if multiple compile jobs report it though

I also pointed this out inline, though I'm not sure why the re-parsing relates to deduplication? We should be able to deduplicate diagnostics whether we parse them again or use the existing ones.

bripeticca added 2 commits November 11, 2025 12:07

owenv reviewed Nov 12, 2025

View reviewed changes

Sources/SwiftBuildSupport/SwiftBuildSystem.swift Outdated Show resolved Hide resolved

bripeticca added 5 commits November 13, 2025 13:33

Implement per-task-buffer of Data output

b1ff231

Fallback to locationContext if locationContext2 properties are nil

ac6b81b

Merge branch 'main' into swb/diagnosticcodesnippet

1ae0f38

Cleanup; add descriptions related to redundant task output

b81bfca

attempt to parse decoded string into individual diagnostics

f3aaabf

bripeticca force-pushed the swb/diagnosticcodesnippet branch from a20f020 to f3aaabf Compare November 20, 2025 18:56

cleanup

c48e606

bripeticca force-pushed the swb/diagnosticcodesnippet branch from 1dcaaeb to c48e606 Compare November 20, 2025 18:58

bripeticca changed the title ~~[WIP] Capture code snippet from diagnostic compiler output~~ Capture code snippet from diagnostic compiler output Nov 20, 2025

bripeticca marked this pull request as ready for review November 20, 2025 19:21

bripeticca requested review from bkhouri, cmcgee1024, daveyc123, dschaefer2, jakepetroules, plemarquand and rconnell9 as code owners November 20, 2025 19:21

owenv reviewed Nov 20, 2025

View reviewed changes

jakepetroules reviewed Nov 20, 2025

View reviewed changes

jakepetroules reviewed Nov 21, 2025

View reviewed changes

Capture code snippet from diagnostic compiler output #9362

Are you sure you want to change the base?

Capture code snippet from diagnostic compiler output #9362

Conversation

bripeticca commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Key Changes

Uh oh!

Uh oh!

bripeticca commented Nov 20, 2025

Uh oh!

owenv left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bripeticca Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jakepetroules commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bripeticca commented Nov 11, 2025 •

edited

Loading

bripeticca Nov 21, 2025 •

edited

Loading