Remove triple from SwiftBuild system output path #9370
Conversation
bkhouri
requested review from
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
rconnell9
as code owners
|
@swift-ci test |
| // can be used to build for any Apple platform and it has its own | ||
| // conventions for build subpaths based on platforms. | ||
| return "apple" | ||
| case .swiftbuild, .native: |
There was a problem hiding this comment.
While the new and old build systems coexist I wonder if we should include "swift-build" here to separate build products for users switching between the two. Not sure I have a strong opinion here
There was a problem hiding this comment.
All build systems can co-exists together today.
Xcode has: .build/apple/Products/<configuration>
Swift Build has: .build/Products/<configuration>
native has: .build/<triple>/<configuration>
There was a problem hiding this comment.
There are other things in the scratch path than build output. We may add more over time. I'm with Owen, we should have a directory for the build system. I would use the build system name "swiftbuild". Save us a character with the path length issues we've had. :)
There was a problem hiding this comment.
"Products" also isn't accurate because this directory contains more than just products (also intermediates and build system bookkeeping state).
I wouldn't use "swiftbuild", it just feels weird to have the component name as part of the path. Maybe just "out"?
There was a problem hiding this comment.
I also thought of just "build".
There was a problem hiding this comment.
.build/build is a little strange looking though
There was a problem hiding this comment.
You can always change the scratch-path to be not .build if it bugs you :)
There was a problem hiding this comment.
it would be a bigger impact changing the default scratch path directory.
From a SwiftPM perspective, the Products and Intermediates are siblings. Here's a sample where SwiftPM puts the SwiftBuild output in a <scratchPath>/out directory.
❯ ls .foo/out
CompilationCache.noindex Intermediates.noindex ModuleCache.noindex Products SDKStatCaches.noindex
❯ ls .foo/out/Products
Debug
There was a problem hiding this comment.
I mean the user can change it. I'm just trying to make sure people are thinking about the scratch path as a directory SwiftPM can put any scratch files into, not just build output. And that it's not always named .build.
There was a problem hiding this comment.
I guess we can rename the default scratch path directory as we have subcommands that deal with cleaning the build output (swift package clean) and all files produced by SwiftPM (swift package reset).
Developers should be using swift package reset instead of rm -rf <scratch-path-directory>.
bkhouri
force-pushed
the
t/main/remove_triple_from_build_output
branch
from
dbcef71 to
9208a2d
Compare
|
@swift-ci test |
bkhouri
force-pushed
the
t/main/remove_triple_from_build_output
branch
from
9208a2d to
7f8e26b
Compare
|
@swift-ci test |
|
@swift-ci test windows |
bkhouri
force-pushed
the
t/main/remove_triple_from_build_output
branch
from
7f8e26b to
c1e869e
Compare
|
@swift-ci test |
|
@swift-ci test windows |
The triple name in the SwiftBuild build system is redundant. Remove the triple from the output path.
bkhouri
force-pushed
the
t/main/remove_triple_from_build_output
branch
from
c1e869e to
85d5e13
Compare
|
@swift-ci test |
|
@swift-ci test windows |
| // can be used to build for any Apple platform and it has its own | ||
| // conventions for build subpaths based on platforms. | ||
| return "apple" | ||
| case .swiftbuild, .native: |
There was a problem hiding this comment.
I mean the user can change it. I'm just trying to make sure people are thinking about the scratch path as a directory SwiftPM can put any scratch files into, not just build output. And that it's not always named .build.
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
|
@swift-ci test |
|
@swift-ci test self hosted windows |
|
@swift-ci please test self hosted windows |
4 participants
The triple name in the SwiftBuild build system is redundant. Remove the triple from the output path.