SwiftBuild: Add index store support #9388
Draft
+449
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
reviewed
Nov 17, 2025
| let fileSystem: FileSystem | ||
|
|
||
| /// The build parameters | ||
| let buildParameters: BuildParameters |
Contributor
There was a problem hiding this comment.
We should avoid passing all the build parameters into the PIF builder, because generally things like platform changes shouldn't affect the output. Could we unconditionally encode the "auto" behavior in the PIF, and then override it to YES or NO in the build request if needed?
Contributor
Author
There was a problem hiding this comment.
Good call, I'll give that a try!
bkhouri
commented
Nov 17, 2025
| $0.severity == .error | ||
| }.isEmpty) | ||
|
|
||
| pif.workspace.projects.forEach({ project in |
Contributor
Author
There was a problem hiding this comment.
chore: remove this code block.
bkhouri
force-pushed
the
t/main/gh9325_rdar163961900_integrate_index-store-with-swift-build
branch
3 times, most recently
from
93e0475 to
9855f6c
Compare
Update the PIF builder to take into account of the `--[auto|disable|enable]-index-store` command line option. When set to `auto`, the PIF builder behaviour does the same as the Native build system. Fixes: swiftlang#9325 Issue: rdar://163961900
bkhouri
force-pushed
the
t/main/gh9325_rdar163961900_integrate_index-store-with-swift-build
branch
from
9855f6c to
5c79ce1
Compare
This was referenced Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the PIF builder to take into account of the
--[auto|disable|enable]-index-storecommand line option.When set to
auto, the PIF builder behaviour does the same as the Native build system.Fixes: #9325
Issue: rdar://163961900