Merge main into release/6.3
#9401
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it's correct everywhere, not only for macOS, Windows, and Linux. Main motivation was for FreeBSD, and will also work for Android, Wasm, iOS, etc.
Reverts #7239 Fails on some linux distros
…9361) Adds `swift test --experimental-maximum-parallelization-width`. This flag passes through to Swift Testing. We may end up just reusing `--num-workers` but as it's not exactly the same feature, I'm keeping it separate for now pending discussion and review.
Re-apply #9374 which reverts #7239. Fix Linux arm build; replacing arm64 -> aarch64; Ubuntu test passes. Fixes #9372 Prior it was failing with: ``` swift-package-manager/.build/aarch64-unknown-linux-gnu/debug/swift-run --package-path /tmp/Miscellaneous_LibraryEvolutionLinuxXCF.07p2Rv/TestBinary --configuration debug --build-system native --scratch-path /tmp/Miscellaneous_LibraryEvolutionLinuxXCF.07p2Rv/TestBinary/.build-test --experimental-xcframeworks-on-linux TestBinary output: Building for debugging... [0/5] Write sources [1/5] Write swift-version--1B491C3C2A126B95.txt error: emit-module command failed with exit code 1 (use -v to see invocation) [3/7] Emitting module TestBinary /tmp/Miscellaneous_LibraryEvolutionLinuxXCF.07p2Rv/TestBinary/Sources/TestBinary/Main.swift:1:8: error: no such module 'SwiftFramework' 1 | import SwiftFramework | `- error: no such module 'SwiftFramework' 2 | 3 | print("Latest Framework with LibraryEvolution version: \(SwiftFrameworkWithEvolution.latest)") [4/7] Compiling TestBinary Main.swift /tmp/Miscellaneous_LibraryEvolutionLinuxXCF.07p2Rv/TestBinary/Sources/TestBinary/Main.swift:1:8: error: no such module 'SwiftFramework' 1 | import SwiftFramework | `- error: no such module 'SwiftFramework' 2 | 3 | print("Latest Framework with LibraryEvolution version: \(SwiftFrameworkWithEvolution.latest)") ✘ Test libraryEvolutionLinuxXCFramework() failed after 2.350 seconds with 1 issue. ```
Swift Build and SwiftPM will adopt this package soon, but first we need to stage it in as a dependency of the bootstrap build
…s a performance degradation in TargetSourcesBuilder (#9385) Avoid expensive string array operations when performing target source evaluation. Local timings for target source evaluation of protoc before and after: **Before:** 'swift-protobuf': TargetSourcesBuilder.run() for target 'protoc' took 11.544s **After:** 'swift-protobuf': TargetSourcesBuilder.run() for target 'protoc' took 0.190s CPU cycles for full build of swift-protobuf: **Before:** 33.43 G **After:** 5.72 G Motivation: Fixes: #9304
- this test seems to cause a crash in libcrypto rdar://134238535
The code to build up the SPECIALIZATION_SDK_OPTIONS list was appending to the existing list, but the list is not guarenteed to be initialized. If it isn't initialized, the append never happens and the setting is dropped.
Known issues: * #9393 * We are only building, and not running testing due to timeout. * Testing for Swift SDK for Android and static sdk are currently disabled.
bkhouri
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
rconnell9
as code owners
Contributor
|
@swift-ci test |
1 similar comment
Contributor
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically opened by a GitHub action. Review the changes included in this PR and determine if they should be included in the release branch. If yes, merge the PR. Otherwise revert changes that should not be included on this branch.