Improve uvt #85526
Open
Improve uvt #85526
+178
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't try to add expected lines in files that aren't parsed for them - it will just lead to duplicated expected lines if run over and over. Because we don't know whether the right choice is to add -verify-additional-file or -verify-ignore-unrelated, we do nothing.
When folding up lines of nested expansions, the line number would be off by 1, which would lead to lines being shuffled around.
DiagnosticVerifier lexes the contents of expected diagnostics the same way Swift parses string literals, to allow for escape codes. This makes for problems when backslashes are followed by something that makes for a valid escape. In particular, it reaches an llvm_unreachable if it encounters `\(`, which would create a string interpolation in a string literal.
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
blocked by #85528 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some bugs in update-verify-tests.