fix: harden path handling, validate HTTP methods, tighten default perms#3
Open
victalejo wants to merge 1 commit into
Open
fix: harden path handling, validate HTTP methods, tighten default perms#3victalejo wants to merge 1 commit into
victalejo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exec.Command("rm", "-rf", pvDirectory+"/*")por borrado nativo en Go (os.ReadDir+os.RemoveAllconfilepath.Join). Además de eliminar la concatenación insegura de paths, corrige un bug latente:exec.Commandno pasa por shell, así que el*nunca se expandía yrmintentaba borrar un archivo llamado literalmente*.GET/POST/PUT/DELETE/PATCH/HEAD/OPTIONS) antes de pasarlo acurl -XenRestoreFromURLyBackupToURL. Antes se aceptaba cualquier string del flag--http-method.0777a0755encli.go(init de/appymkdirdel file-op).