-
Notifications
You must be signed in to change notification settings - Fork 641
feat: support customizable alignment for image display #1897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for the PR! Could you please just change the key parts and pull out the refactoring into a new PR? That would make the review a bit easier. |
Exposing `image_area` separately allows future Lua integration to handle image placement more flexibly, without needing to invoke full rendering. This change promotes modularity and simplifies obtaining image dimensions alone. This refactor provides the foundation for feature PR sxyazi#1897, preparing for easier integration.
2fad7d8 to
37a19b6
Compare
|
This PR currently introduces the ability to customize the alignment for image display by adding a third parameter to the
Next StepsOpen to feedback on improving specific implementation details or considering alternative approaches. |
f2e33da to
c65bdb3
Compare
2b70f8d to
5e48df5
Compare
43473db to
d72f903
Compare
a9c693e to
86f4659
Compare
1cc8e5a to
a29dbb9
Compare
d1efbb8 to
a0ab614
Compare
35d9907 to
2768fd2
Compare
9f077f9 to
60a2382
Compare
This is an attempt to provide a possible solution to #1141.
yazi.tomlfor setting preferred image alignment, which plugin developers can optionally respect.PREVIEW.alignmentfor aligned image display.It appears to work well overall, though some aspects remain unclear:
serdealign with usual practices?