Skip to content

fix: skip backup warning after wallet restore #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ovitrif merged 6 commits into from
Jan 30, 2026
+24 −0
Merged

fix: skip backup warning after wallet restore #747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
397fb1a
fix: set backupVerified as true on restore with success
jvsena42 Jan 29, 2026
18c0979
test: restoreWallet should set backupVerified to true on success
jvsena42 Jan 29, 2026
580315b
Merge branch 'master' into fix/disable-timed-sheet-after-restore
jvsena42 Jan 29, 2026
9a846ac
fix: move backupVerified to repository
jvsena42 Jan 29, 2026
ab96f9a
test: restoreWallet backupVerified repo tests
jvsena42 Jan 29, 2026
5c57a18
Merge remote-tracking branch 'origin/fix/disable-timed-sheet-after-re…
jvsena42 Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/src/main/java/to/bitkit/repositories/WalletRepo.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,8 @@ class WalletRepo @Inject constructor(
keychain.saveString(Keychain.Key.BIP39_PASSPHRASE.name, bip39Passphrase)
}
setWalletExistsState()
}.onSuccess {
settingsStore.update { it.copy(backupVerified = true) }
}.onFailure {
Logger.error("restoreWallet error", it, context = TAG)
}
Expand Down
22 changes: 22 additions & 0 deletions app/src/test/java/to/bitkit/repositories/WalletRepoTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,28 @@ class WalletRepoTest : BaseUnitTest() {
verify(keychain).saveString(Keychain.Key.BIP39_MNEMONIC.name, mnemonic)
}

@Test
fun `restoreWallet should set backupVerified to true on success`() = test {
val mnemonic = "restore mnemonic"
whenever(keychain.saveString(any(), any())).thenReturn(Unit)

val result = sut.restoreWallet(mnemonic, null)

assertTrue(result.isSuccess)
verify(settingsStore).update(any())
}

@Test
fun `restoreWallet should not set backupVerified when keychain fails`() = test {
val mnemonic = "restore mnemonic"
whenever(keychain.saveString(any(), any())).thenThrow(error)

val result = sut.restoreWallet(mnemonic, null)

assertTrue(result.isFailure)
verify(settingsStore, never()).update(any())
}

@Test
fun `refreshBip21 should generate new address when current is empty`() = test {
whenever(lightningRepo.newAddress()).thenReturn(Result.success(ADDRESS_NEW))
Expand Down
Loading