Skip to content

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Jan 30, 2026

Fixes #648

This PR removes the tap action from the balance header on the received/sent confetti sheet to prevent unintended sheet dismissal.

Description

When receiving or sending a payment, the confetti sheet displays a balance header showing the transaction amount. Previously, tapping this amount would close the sheet, which was confusing and unexpected. On iOS, this same interaction swaps between bitcoin and fiat display. This fix removes the onClick handler from the BalanceHeaderView in NewTransactionSheet to match expected behavior.

Preview

receive.webm
send.webm

QA Notes

1. Tap amount on received confetti sheet

  1. Receive a payment (LN or on-chain)
  2. Wait for the confetti sheet to appear
  3. Tap on the bitcoin amount displayed
  4. Verify the sheet remains open (does not dismiss)

2. Tap amount on sent confetti sheet

  1. Send a payment (LN or on-chain)
  2. Wait for the confetti sheet to appear
  3. Tap on the bitcoin amount displayed
  4. Verify the sheet remains open (does not dismiss)

3. Regression - Sheet dismissal

  1. Receive or send a payment
  2. Verify the sheet can still be dismissed by:
    • Tapping the close button
    • Swiping down
    • Tapping outside the sheet content

@jvsena42 jvsena42 self-assigned this Jan 30, 2026
@jvsena42 jvsena42 requested a review from ovitrif January 30, 2026 12:08
@claude
Copy link

claude bot commented Jan 30, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@jvsena42 jvsena42 enabled auto-merge January 30, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Tapping amount in received or sent confetti sheet closes the sheet

2 participants