Open
Conversation
Member
Author
|
This could be simplified by having the EC only support building a single version. That is, put everything in I don't expect that to affect anyone but me, since I regularly diff the |
crawfxrd
force-pushed
the
ec-version
branch
2 times, most recently
from
365bc2d to
57a15b7
Compare
crawfxrd
force-pushed
the
ec-version
branch
2 times, most recently
from
f040cc9 to
d002b8e
Compare
crawfxrd
force-pushed
the
ec-version
branch
2 times, most recently
from
e0d7fc3 to
738bb0b
Compare
jacobgkau
previously approved these changes
Oct 20, 2023
Member
jacobgkau
left a comment
jacobgkau
left a comment
There was a problem hiding this comment.
The build and flash scripts seem to still be working as expected. Tried on an existing clone and a fresh clone of the repo on lemp10.
leviport
previously approved these changes
Feb 21, 2024
Member
leviport
left a comment
leviport
left a comment
There was a problem hiding this comment.
Working as expected on a gaze16-3050.
leviport
previously approved these changes
Feb 29, 2024
The original rationale for having the EC version match the SBIOS version was to ensure that compatible versions of each were installed. So we set the EC version to the SBIOS version and always flash both of them, even if only one actually changed. At some point, a mechanism should be implemented that checks for a minimum supported/compatible version. This would be comparable to the LVFS MetaInfo's "requires" field. Ref: f4f4d5b ("Build EC as a submodule, specifying version") Signed-off-by: Tim Crawford <tcrawford@system76.com>
leviport
previously approved these changes
Feb 29, 2024
The original rationale for having the EC version match the SBIOS version was to ensure that compatible versions of each were installed. So we set the EC version to the SBIOS version and always flash both of them, even if only one actually changed. At some point, a mechanism should be implemented that checks for a minimum supported/compatible version. This would be comparable to the LVFS MetaInfo's "requires" field. Ref: f4f4d5b ("Build EC as a submodule, specifying version") Signed-off-by: Tim Crawford <tcrawford@system76.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop setting the EC version to the SBIOS version so that the EC will use its real version.
The original rationale for having the EC version match the SBIOS version was to ensure that compatible versions of each were installed. So we set the EC version to the SBIOS version and always flash both of them, even if only one actually changed.
At some point, a mechanism should be implemented that checks for a minimum supported/compatible version. This would be comparable to the LVFS MetaInfo's "requires" field. (UEFI requires the firmware version be a 32-bit unsigned integer, which would simplify the comparison.)
Resolves: #434