chore: upgrade datafusion dependencies from 53 to 54 - #99
Merged
Conversation
- Bump all datafusion workspace crates from 53 to 54.1.0 - Remove implementations that were removed from ExecutionPlan and TableProvider traits - Update downcast calls in codec.rs to use - Wrap partition_statistics return value in Arc to match new trait signature Build, clippy, and fmt all pass.
DataFusion 54 provides `downcast_ref::<T>()` and `is::<T>()` as inherent methods on `dyn ExecutionPlan`, available on `Arc<dyn ExecutionPlan>` via auto-deref. This is cleaner than `(&*node as &dyn Any).downcast_ref()` and correctly handles `downcast_delegate()` for wrapper plans.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade all DataFusion workspace dependencies from 53 to 54.1.0.
Changes
as_any()(removed fromExecutionPlantrait), wrappartition_statisticsreturn inArcto match new trait signature, remove unusedstd::any::Anyimportas_any()(removed fromExecutionPlantrait)as_any()(removed fromTableProvidertrait), remove unusedstd::any::Anyimportnode.as_any().downcast_ref()with(&*node as &dyn Any).downcast_ref()sinceExecutionPlan: Anybut no longer exposesas_any()Verification
cargo build --workspacepassescargo clippy -- -D warningspassescargo fmt --allpasses