Fix sample README drift: wrong flag, fork links, missing requirements, wrong variable names - #119
Open
ZayanKhan-12 wants to merge 4 commits into
Open
Fix sample README drift: wrong flag, fork links, missing requirements, wrong variable names#119ZayanKhan-12 wants to merge 4 commits into
ZayanKhan-12 wants to merge 4 commits into
Conversation
Both scripts define path_to_repo as a positional argument (the README's own embedded usage output shows this), so the documented commands exit with 'unrecognized arguments: --path_to_repo'. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The s3-compatible-services and git-to-hyper index entries linked the contributor's fork (aetperf) instead of tableau/hyper-api-samples like every other entry. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The README instructs installing dependencies from requirements.txt, but the sample shipped without one; the script's only third-party import is tableauhyperapi (same pin as the sibling native-s3 sample). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The script's variables are hyper_file_path and table_name; hyper_name and my_table exist nowhere in hyper-to-csv.py. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Thanks for the contribution! Before we can merge this, we need @zk-khan to sign the Salesforce Inc. Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four commits, each independently revertible:
--path_to_repo, but both scripts definepath_to_repoas a positional argument (the README's own embedded usage output shows this); as written the commands exit withunrecognized arguments.s3-compatible-servicesandgit-to-hyperentries linked the contributor's fork (github.com/aetperf/...) instead of this repository, unlike every other entry.requirements.txt, but the sample shipped without one; added it with the sample's only third-party import (tableauhyperapi, same pin as the sibling native-s3 sample).hyper_nameandmy_table; the script's variables arehyper_file_pathandtable_name(the documented names exist nowhere in the script).Verification: argparse definitions and variable names grep-verified against each script; both corrected index targets exist in this repo;
python -m py_compileclean on all touched samples. (The repository has no test suite or CI to run.)Prepared with AI assistance (Claude).