You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot has reviewed my latest changes, and all comments have been fixed and/or closed.
If I have made database changes, I have made sure I followed all the db repo rules listed in the wiki here. (check if no db changes)
All tests have passed
I have successfully deployed this PR to staging
I have done manual QA in both dev (and staging if possible) and attached screenshots below.
Screenshots
Dev
I thought the black/white badge colors were too beaming for the eyes and did not go well with the design we are currently, please LMK if you would like it to be changed! :)
Staging
N/A: the waiting duel page relies on a lobby code so testing in staging wouldn't really make sense
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces a new waiting lobby UI component for the LeetCode duel feature. The component displays a lobby screen where two players can join, mark themselves as ready, and wait for the host to start the duel.
Key Changes:
New DuelWaitingScreen component with player cards, lobby code display, and ready status indicators
Real-time status updates showing when both players are ready
Host-controlled "Start Duel" button that becomes enabled when both players are ready
FROZENThis PR is currently frozen - likely due to a team-wide hiatus
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tahminator
added
the
FROZEN
Notion Ticket (use public link, not private)
https://www.notion.so/0pengu/Define-the-initial-UI-when-waiting-for-a-duel-to-begin-2b67c85563aa80298babdc983aa8dcef
Description of changes
Screenshots
Dev
I thought the black/white badge colors were too beaming for the eyes and did not go well with the design we are currently, please LMK if you would like it to be changed! :)
Staging
N/A: the waiting duel page relies on a lobby code so testing in staging wouldn't really make sense