566 expiresAt should be null on party creation, only set once duel starts #603

angelayu0530 · 2026-01-04T20:27:11Z

566

changed so expire at is null when creating and then sets a expire at when starts

Description of changes

Checklist before review

I have done a thorough self-review of the PR
Copilot has reviewed my latest changes, and all comments have been fixed and/or closed.
If I have made database changes, I have made sure I followed all the db repo rules listed in the wiki here. (check if no db changes)
All tests have passed
I have successfully deployed this PR to staging
I have done manual QA in both dev (and staging if possible) and attached screenshots below.

Screenshots

Staging

When Create Party:

When Started

angelayu0530 · 2026-01-04T20:27:31Z

/deploy

github-actions · 2026-01-04T20:28:02Z

The command to deploy to staging for the commit fe75603 has been triggered. View action run

github-actions · 2026-01-04T20:28:35Z

Staging deployment failed for commit fe75603

**

View run

greptile-apps · 2026-01-04T20:29:40Z

Greptile Summary

Changed party lifecycle so expiresAt is null on creation and set to 30 minutes when the duel starts via DuelManager.startDuel().

Key changes:

PartyManager.createParty() now sets expiresAt to null instead of now() + 30 minutes
DuelManager.startDuel() sets expiresAt to now() + 30 minutes when transitioning lobby from AVAILABLE to ACTIVE
Added null checks in PartyManager.joinParty() and DuelManager.endDuel() to handle expiresAt being null
Removed unused OffsetDateTime import from PartyManager.java

Issues found:

Tests in PartyManagerTest.java (lines 72 and 153-177) will fail because they expect expiresAt to be set on party creation

Confidence Score: 2/5

Tests will fail - requires test updates before merge
Logic changes are correct and properly handle null checks, but existing tests assert expiresAt is not null on party creation, which will cause test failures
PartyManagerTest.java needs updates to align with the new behavior where expiresAt is null on party creation

Important Files Changed

Filename	Overview
src/main/java/com/patina/codebloom/common/components/duel/PartyManager.java	Changed `expiresAt` to null on party creation; removed unused import
src/main/java/com/patina/codebloom/common/components/duel/DuelManager.java	Sets `expiresAt` to 30 minutes when duel starts; adds null check in `endDuel`

Sequence Diagram

sequenceDiagram
    participant User
    participant PartyManager
    participant DuelManager
    participant Lobby
    participant LobbyRepository

    Note over User,LobbyRepository: Party Creation Flow
    User->>PartyManager: createParty(userId)
    PartyManager->>LobbyRepository: createLobby(lobby)
    Note over Lobby: expiresAt = null
    Note over Lobby: status = AVAILABLE
    LobbyRepository-->>PartyManager: success
    PartyManager-->>User: joinCode

    Note over User,LobbyRepository: Duel Start Flow
    User->>DuelManager: startDuel(playerId)
    DuelManager->>LobbyRepository: findLobbyById(lobbyId)
    LobbyRepository-->>DuelManager: lobby
    DuelManager->>Lobby: setStatus(ACTIVE)
    DuelManager->>Lobby: setExpiresAt(now + 30 minutes)
    DuelManager->>LobbyRepository: updateLobby(lobby)
    LobbyRepository-->>DuelManager: success
    DuelManager-->>User: duel started

    Note over User,LobbyRepository: Join Party Flow
    User->>PartyManager: joinParty(userId, partyCode)
    PartyManager->>LobbyRepository: findAvailableLobbyByJoinCode(partyCode)
    LobbyRepository-->>PartyManager: lobby
    alt expiresAt != null AND expired
        PartyManager-->>User: DuelException: lobby expired
    else valid
        PartyManager->>LobbyRepository: updateLobby(lobby)
        PartyManager-->>User: joined successfully
    end

    Note over User,LobbyRepository: End Duel Flow
    User->>DuelManager: endDuel(lobbyId, isDuelCleanup)
    DuelManager->>LobbyRepository: findLobbyById(lobbyId)
    LobbyRepository-->>DuelManager: lobby
    alt expiresAt != null AND not expired AND not cleanup
        DuelManager-->>User: DuelException: not ready for expiration
    else can end
        DuelManager->>Lobby: setStatus(COMPLETED)
        DuelManager->>LobbyRepository: updateLobby(lobby)
        DuelManager-->>User: duel ended
    end

greptile-apps

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

src/main/java/com/patina/codebloom/common/components/duel/PartyManager.java

github-actions · 2026-01-04T20:32:37Z

Commit Validation Failed

The following commits do not start with the required Notion ID 566:

spotless

Please rebase and update your commit messages.
All messages should be of the following format: 566: Example commit

angelayu0530 · 2026-01-04T20:33:00Z

/deploy

github-actions · 2026-01-04T20:33:29Z

The command to deploy to staging for the commit 6c995c4 has been triggered. View action run

github-actions · 2026-01-04T20:37:46Z

Staging deployment failed for commit 6c995c4

**

View run

github-actions · 2026-01-04T20:46:34Z

Commit Validation Failed

The following commits do not start with the required Notion ID 566:

test errors

Please rebase and update your commit messages.
All messages should be of the following format: 566: Example commit

angelayu0530 · 2026-01-04T20:48:47Z

/deploy

github-actions · 2026-01-04T20:49:16Z

The command to deploy to staging for the commit 7e5113f has been triggered. View action run

github-actions · 2026-01-04T20:50:09Z

Overall Project	72.48%	🍏
Files changed	100%	🍏

File	Coverage
PartyManager.java	92.94%	🍏
DuelManager.java	92.15%	🍏

github-actions · 2026-01-04T20:56:54Z

Overall Project	72.48%	🍏
Files changed	100%	🍏

File	Coverage
PartyManager.java	92.94%	🍏
DuelManager.java	92.15%	🍏

github-actions · 2026-01-04T21:02:32Z

Staging deployment succeeded for commit 7e5113f

View run

angelayu0530 · 2026-01-04T23:58:38Z

/deploy

github-actions · 2026-01-04T23:59:09Z

The command to deploy to staging for the commit 9a5d1e0 has been triggered. View action run

github-actions · 2026-01-04T23:59:45Z

Staging deployment failed for commit 9a5d1e0

**

View run

github-actions · 2026-01-05T00:01:43Z

Commit Validation Failed

The following commits do not start with the required Notion ID 566:

spotless changes

Please rebase and update your commit messages.
All messages should be of the following format: 566: Example commit

angelayu0530 · 2026-01-05T00:02:16Z

/deploy

github-actions · 2026-01-05T00:02:50Z

The command to deploy to staging for the commit 03a7ba3 has been triggered. View action run

github-actions · 2026-01-05T00:06:20Z

Overall Project	72.47%	🍏
Files changed	100%	🍏

File	Coverage
PartyManager.java	92.89%	🍏
DuelManager.java	92.15%	🍏

github-actions · 2026-01-05T00:17:10Z

Staging deployment succeeded for commit 03a7ba3

View run

angelayu0530 · 2026-01-05T00:35:07Z

/deploy

github-actions · 2026-01-05T00:35:38Z

The command to deploy to staging for the commit 48224b4 has been triggered. View action run

github-actions · 2026-01-05T05:39:47Z

Staging deployment failed for commit 1716814

**

View run

angelayu0530 · 2026-01-05T05:41:45Z

/deploy

github-actions · 2026-01-05T05:42:11Z

The command to deploy to staging for the commit 4c9a85e has been triggered. View action run

github-actions · 2026-01-05T05:46:38Z

Staging deployment failed for commit 4c9a85e

**

View run

angelayu0530 · 2026-01-05T05:48:33Z

/deploy

github-actions · 2026-01-05T05:49:08Z

The command to deploy to staging for the commit b76be29 has been triggered. View action run

github-actions · 2026-01-05T05:53:51Z

Staging deployment failed for commit b76be29

**

View run

angelayu0530 · 2026-01-05T05:59:50Z

/deploy

github-actions · 2026-01-05T06:00:21Z

The command to deploy to staging for the commit c031856 has been triggered. View action run

github-actions · 2026-01-05T06:00:58Z

Staging deployment failed for commit c031856

**

View run

angelayu0530 · 2026-01-05T06:04:31Z

/deploy

github-actions · 2026-01-05T06:05:01Z

The command to deploy to staging for the commit 2b7b0e2 has been triggered. View action run

github-actions · 2026-01-05T06:09:11Z

Overall Project	74.69%	🍏
Files changed	98.44%	🍏

File	Coverage
PartyManager.java	100%	🍏
DuelManager.java	92.1%	🍏
LobbySqlRepository.java	86.69% `-0.14%`	🍏

github-actions · 2026-01-05T06:19:12Z

Staging deployment succeeded for commit 2b7b0e2

View run

src/main/java/com/patina/codebloom/common/components/duel/PartyManager.java

… once duel starts spotless test errors bug fix spotless changes forgot db migration had to update lobby repo

same thing Naming changes

changes changes spotless testing changes test changes spotless pr changes

github-actions · 2026-01-05T06:41:39Z

Overall Project	76.79%	🍏
Files changed	98.33%	🍏

File	Coverage
PartyManager.java	100%	🍏
DuelManager.java	92.1%	🍏
LobbySqlRepository.java	86.69% `-0.14%`	🍏

github-actions · 2026-01-05T06:48:23Z

Overall Project	76.79%	🍏
Files changed	98.33%	🍏

File	Coverage
PartyManager.java	100%	🍏
DuelManager.java	92.1%	🍏
LobbySqlRepository.java	86.69% `-0.14%`	🍏

greptile-apps bot reviewed Jan 4, 2026

View reviewed changes

src/main/java/com/patina/codebloom/common/components/duel/PartyManager.java Outdated Show resolved Hide resolved

angelayu0530 force-pushed the sse-end-change branch from 53b45d3 to 6c995c4 Compare January 4, 2026 20:32

angelayu0530 force-pushed the sse-end-change branch from 2b73c68 to 7e5113f Compare January 4, 2026 20:46

angelayu0530 force-pushed the sse-end-change branch from 7e5113f to 9a5d1e0 Compare January 4, 2026 23:58

angelayu0530 force-pushed the sse-end-change branch from 2dbb85a to 03a7ba3 Compare January 5, 2026 00:01

angelayu0530 force-pushed the sse-end-change branch from 03a7ba3 to 48224b4 Compare January 5, 2026 00:34

angelayu0530 force-pushed the sse-end-change branch from 1716814 to 4c9a85e Compare January 5, 2026 05:41

angelayu0530 force-pushed the sse-end-change branch from 4c9a85e to b76be29 Compare January 5, 2026 05:48

angelayu0530 force-pushed the sse-end-change branch from b76be29 to c031856 Compare January 5, 2026 05:59

angelayu0530 force-pushed the sse-end-change branch from c031856 to 2b7b0e2 Compare January 5, 2026 06:04

tahminator requested changes Jan 5, 2026

View reviewed changes

src/main/java/com/patina/codebloom/common/components/duel/PartyManager.java Outdated Show resolved Hide resolved

angelayu0530 force-pushed the sse-end-change branch from 2b7b0e2 to b6ad08a Compare January 5, 2026 06:34

angelayu0530 added 3 commits January 5, 2026 01:36

566: Changing so expiresAt should be null on party creation, only set…

81dc16c

… once duel starts spotless test errors bug fix spotless changes forgot db migration had to update lobby repo

566: Refactored Code from Lobby.java having the switch of optional

4f69d13

same thing Naming changes

566: pr changes

7e2a8d8

changes changes spotless testing changes test changes spotless pr changes

angelayu0530 force-pushed the sse-end-change branch from b6ad08a to 7e2a8d8 Compare January 5, 2026 06:36

angelayu0530 enabled auto-merge (rebase) January 5, 2026 06:36

tahminator approved these changes Jan 5, 2026

View reviewed changes

angelayu0530 merged commit 25ddaa0 into main Jan 5, 2026
12 checks passed

angelayu0530 deleted the sse-end-change branch January 5, 2026 06:43

566 expiresAt should be null on party creation, only set once duel starts #603

566 expiresAt should be null on party creation, only set once duel starts #603

Uh oh!

Conversation

angelayu0530 commented Jan 4, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

566

566

Description of changes

Checklist before review

Screenshots

Staging

Uh oh!

angelayu0530 commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

greptile-apps bot commented Jan 4, 2026

Greptile Summary

Confidence Score: 2/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jan 4, 2026

Commit Validation Failed

Uh oh!

angelayu0530 commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Commit Validation Failed

Uh oh!

angelayu0530 commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

angelayu0530 commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Commit Validation Failed

Uh oh!

angelayu0530 commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

angelayu0530 commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

angelayu0530 commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

angelayu0530 commented Jan 4, 2026 •

edited by github-actions bot

Loading