Testling should specify the encoding when serving the page/bundle. #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Testling didn't specify the charset, this led to a plethora of random encoding errors if the libraries used anything outside of the ASCII charset. The same code would work or not on browsers with the same capabilities depending on whether the browser decided to treat the page as UTF-8 or not. Specifying the charset gets rid of all that and gives us predictable behaviours. Yay
This was referenced May 3, 2013
Collaborator
|
+1, this will help! |
Collaborator
|
@robotlolita would you mind checking "allow edits" on the RHS of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Testling didn't specify the charset, this led to a plethora of random encoding errors if the libraries used anything outside of the ASCII charset. The same code would work or not on browsers with the same capabilities depending on whether the browser decided to treat the page as UTF-8 or not.
Specifying the charset gets rid of all that and gives us predictable behaviours. Yay