Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix CI issues by addressing mypy type checking errors and pytest warnings. The changes focus on making type annotations more explicit and suppressing known deprecation warnings.
Key Changes
- Refactored
redis.set()calls to use explicit named parameters instead of**kwargsto resolve mypy type checking issues - Added
# type: ignorecomments to suppress mypy warnings in redis broker and list schedule source where type issues originate from the redis library - Added pytest warning filter to suppress known deprecation warnings about
RedisScheduleSource
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| taskiq_redis/redis_broker.py | Added type ignore comments for redis operations and updated type hints for additional_streams parameter |
| taskiq_redis/redis_backend.py | Refactored redis.set() calls to use explicit parameters and removed unused Dict import; updated documentation comments |
| taskiq_redis/list_schedule_source.py | Added type ignore comments for redis list operations |
| pyproject.toml | Added pytest configuration to filter deprecation warnings for RedisScheduleSource |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redis.set();casttoAwaitablebut it's basically the same as use ignore;RedisScheduleSourcein tests, because it's known issue and it's okey to have it. In my opinion - pytest results must be clean. If new warnings will be created - they should be fixed or ignored with a good reason.Overall I just want to unblock work in #111 by making CI checks green at least on main.