Add tracking of mentions to tweets#98
Open
AcesoUnderGlass wants to merge 1 commit into
Open
Conversation
Owner
|
I think this PR duplicates the solution proposed in this comment #100 (comment) |
taspinar
reviewed
Mar 14, 2018
|
|
||
| @classmethod | ||
| def from_soup(cls, tweet): | ||
| mentions = [] |
Owner
There was a problem hiding this comment.
This looks a bit cumbersome.
Would it work if you implemented mentions = tweet.find('div', 'tweet')['data-mentions'] or "" on line 47, and subsequently self.mentions = mentions.split() on line 20.
In this case, if the passed argument is an empty string, the applied split() operation will results in an empty list.
taspinar
reviewed
Mar 14, 2018
| self.retweets = retweets | ||
| self.likes = likes | ||
| self.html = html | ||
| self.mentions = mentions |
Owner
There was a problem hiding this comment.
You are never passing the contents of 'mentions' in the from_soup method to this class. (see line 9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes @s and reply-tos.